Code review comment for lp:~paulgear/python-oops-datedir-repo/variable-retention-period

Revision history for this message
Paul Gear (paulgear) wrote :

> Looks good, other than the changed default value for filename. If there's no
> particular reason to change that, it seems best to leave it as-is.

My commit message seems to indicate that that's what is used by the running copy of this code in Launchpad production. I'd have to go back and confirm, but that's the only reason I can think of that I would have changed it.

If you aren't comfortable doing that, feel free to edit out when merging and we can maintain the patch locally in production.

« Back to merge proposal