Code review comment for lp:~paulgear/charms/trusty/memcached/detect-nagios-context-changed

Revision history for this message
Adam Israel (aisrael) wrote :

Hi Paul,

Thanks again for your work on improving the memcached charm. I'm going to have to NACK this merge proposal. The failing tests are due to un-mocked methods. Additionally, there's an undefined variable, local_unit_name, that will fail once the mocking is in place.

« Back to merge proposal