Code review comment for lp:~paulgear/charms/trusty/memcached/correct-nagios-service

Revision history for this message
Paul Gear (paulgear) wrote :

Hi Adam, Brad has provided documentation about this in one of the other MPs for memcached. If you add a relation to nrpe-external-master, it should work.

I'm no longer working on this project, so I don't have the ability to dedicate time to writing tests, but if you review the two nrpe* templates in http://bazaar.launchpad.net/~charmers/charms/trusty/memcached/trunk/files/head:/templates/, you'll see that this MP is critical for the nrpe-external-master relation to function at all (the variables simply don't match what the template is expecting). IMO, it is better for it to be working without a unit test than not working without a unit test.

« Back to merge proposal