Juju Charms Collection
memcached package

Code review comment for lp:~paulgear/charms/trusty/memcached/correct-nagios-service

  1. Trusty Tahr (14.04)
  2. correct-nagios-service
  3. Merge into trunk
Revision history for this message
Adam Israel (aisrael) wrote :

Hi Paul,

Thanks for your work towards improving the memcached charm! I had the opportunity to review this merge proposal today. While the proposed change is minor, I've been unable to test it properly. I added the relation between nagios, nrpe, and memcached but the check_memcached.cfg isn't being rendered.

Ideally, this functionality should be documented in the README and have an amulet test added to demonstrate the nagios relation.

When you're ready, set the status of this MP back to 'Needs Review' and we'll be happy to retest!

review: Needs Fixing

« Back to merge proposal