Code review comment for lp:~paulgear/charms/trusty/memcached/allow-rsync-firewall

Revision history for this message
Brad Marshall (brad-marshall) wrote :

Adam,

> The problem I see is by promoting it to the charm store, we're expecting
> users to know that they need to manually fork the precise version of the
> nrpe-external-master charm to trusty and deploy from local. It's not an
> intuitive process.

I agree, the whole n-e-m interface is one huge hack, since you have to have a copy of nagios running outside of Juju to use it. Its all working around not having cross environment relations. Its not pretty, but its what we have to work with for now.

> If you could expand the README to demystify the process, I'd be happy
> to approve this in the interim.

I've just added a quick description of how to use it - its a bit hacky, but its how we're using the charm for now. Once the nrpe rewrite gets landed we can update things to be neater.

Thanks,
Brad

« Back to merge proposal