Code review comment for lp:~paulgear/charms/trusty/memcached/allow-rsync-firewall

Adam,

> Where are you deploying nrpe-external-master from?

We are using a local copy of the charm from precise, checked out into a trusty directory.

> If you can update the doc to reference nrpe instead of nrpe-external-master,
> we'll re-review this once the nrpe charm lands.

We have production instances of memcached (and other charms) using the nrpe-external-master
relationship - both internally to Canonical and for customers. We need a working
nrpe-external-master interface to continue to support our customers, and these fixes address
shortcomings of the current code introduced in the python rewrite.

I have been talking to Liam about the upcoming nrpe rewrite and will be working with him to
get the charms on which we rely (at least) updated to support the new interface once it lands,
but it will probably be a phased approach to get rid of the nrpe-external-master interface.

Is there any reason not to fix the broken code now? Without this merge, we'll end up maintaining yet another separate branch for customers, which as you know is extra maintenance overhead.

Thanks,
Brad