Code review comment for ~paulgear/charm-openstack-service-checks:master

Revision history for this message
Stuart Bishop (stub) wrote :

Mostly fine, but one bug commented on inline (the restart handler can run much too early).

triggers is an alternative approach to some of this, but docs recommend things the way you have (and I can argue it both ways). https://charmsreactive.readthedocs.io/en/latest/triggers.html#coupling-flags-with-triggers

review: Approve

« Back to merge proposal