Code review comment for lp:~paulgear/charm-helpers/nrpe-service-immediate-check

Revision history for this message
Stuart Bishop (stub) wrote :

Minor inline comments.

I think the default should be immediate_check=True. Charms need to explicitly call add_init_service_checks(), and any charm doing that for a bogus service that hangs on the status check is already broken. It is better to discover that now rather than later when there are a zillion hung /usr/local/lib/nagios/plugins/check_exit_status.pl processes. Or just add timeout(1) to the command line.

review: Abstain

« Back to merge proposal