Merge lp:~paulbrianstewart/ubuntu/oneiric/mplayer/829078-Spelling-Grammar-Fix into lp:ubuntu/oneiric/mplayer
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Colin Watson | ||||
Proposed branch: | lp:~paulbrianstewart/ubuntu/oneiric/mplayer/829078-Spelling-Grammar-Fix | ||||
Merge into: | lp:ubuntu/oneiric/mplayer | ||||
Diff against target: |
67 lines (+10/-12) 1 file modified
debian/control (+10/-12) |
||||
To merge this branch: | bzr merge lp:~paulbrianstewart/ubuntu/oneiric/mplayer/829078-Spelling-Grammar-Fix | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson | Disapprove | ||
Barry Warsaw (community) | Needs Information | ||
Review via email: mp+72241@code.launchpad.net |
Commit message
*Changed the incorrect spelling of "usefule" to "useful"
*Changed incorrect spelling of "fullscreen" to "full-screen"
*Changed "abilities" to "capabilities"
*Changed "You only need these..." to "This package is required..."
*Changed instances of "mplayer" in the documentation text to a consistent "MPlayer" throughout
Description of the change
*Changed the incorrect spelling of "usefule" to "useful"
*Changed incorrect spelling of "fullscreen" to "full-screen"
*Changed "abilities" to "capabilities"
*Changed "You only need these..." to "This package is required..."
*Changed instances of "mplayer" in the documentation text to a consistent "MPlayer" throughout
Unmerged revisions
- 78. By Paul Stewart
-
*Removed the libfaac-dev in the build-depends that I incorrectly copied from the medibuntu.natty control file
*Changed the uploaders and maintainer info back to what is in the ubuntu/mplayer control from
- 77. By Paul Stewart
-
*Changed the incorrect spelling of "usefule" to "useful"
*Changed incorrect spelling of "fullscreen" to "full-screen"
*Changed "abilities" to "capabilities"
*Changed "You only need these..." to "This package is required..."
*Changed instances of "mplayer" in the documentation text to a consistent "MPlayer" throughout
Hi Paul, thanks for you contribution to Ubuntu.
The only change I'm not so sure about is fullscreen -> full-screen. I think it should probably be written "full screen" without the hyphen.
Also, it would probably be best to submit this bug report and patch to Debian, and then let us sync it to Ubuntu, rather than carry an Ubuntu-specific delta. Would you be willing to do that?