Merge lp:~paulbrianstewart/ubuntu/oneiric/mplayer/829078-Spelling-Grammar-Fix into lp:ubuntu/oneiric/mplayer

Proposed by Paul Stewart
Status: Rejected
Rejected by: Colin Watson
Proposed branch: lp:~paulbrianstewart/ubuntu/oneiric/mplayer/829078-Spelling-Grammar-Fix
Merge into: lp:ubuntu/oneiric/mplayer
Diff against target: 67 lines (+10/-12)
1 file modified
debian/control (+10/-12)
To merge this branch: bzr merge lp:~paulbrianstewart/ubuntu/oneiric/mplayer/829078-Spelling-Grammar-Fix
Reviewer Review Type Date Requested Status
Colin Watson Disapprove
Barry Warsaw (community) Needs Information
Review via email: mp+72241@code.launchpad.net

Commit message

*Changed the incorrect spelling of "usefule" to "useful"
*Changed incorrect spelling of "fullscreen" to "full-screen"
*Changed "abilities" to "capabilities"
*Changed "You only need these..." to "This package is required..."
*Changed instances of "mplayer" in the documentation text to a consistent "MPlayer" throughout

Description of the change

*Changed the incorrect spelling of "usefule" to "useful"
*Changed incorrect spelling of "fullscreen" to "full-screen"
*Changed "abilities" to "capabilities"
*Changed "You only need these..." to "This package is required..."
*Changed instances of "mplayer" in the documentation text to a consistent "MPlayer" throughout

To post a comment you must log in.
78. By Paul Stewart

*Removed the libfaac-dev in the build-depends that I incorrectly copied from the medibuntu.natty control file

*Changed the uploaders and maintainer info back to what is in the ubuntu/mplayer control from

Revision history for this message
Barry Warsaw (barry) wrote :

Hi Paul, thanks for you contribution to Ubuntu.

The only change I'm not so sure about is fullscreen -> full-screen. I think it should probably be written "full screen" without the hyphen.

Also, it would probably be best to submit this bug report and patch to Debian, and then let us sync it to Ubuntu, rather than carry an Ubuntu-specific delta. Would you be willing to do that?

review: Needs Information
Revision history for this message
Paul Stewart (paulbrianstewart) wrote :

Hi Barry,

Sure, I'll send up a bug report to Debian. The problem is I can't seem to get it to work. I am using the following commands:

paul@pl:~$ reportbug -B mplayer
Ignored bogus setting for -B: mplayer
*** ERROR: "Ubuntu" BTS is currently unsupported. Please use "ubuntu-bug" (from
the apport package) for reporting bugs in Ubuntu. You can report bugs to Debian
by specifying 'bts debian' in your ~/.reportbugrc or by passing the -B debian
option on the commandline (see reportbug(1)).

What am I doing wrong? Are you able to advise me please?

Thanks
Paul

Revision history for this message
Paul Stewart (paulbrianstewart) wrote :

> Hi Paul, thanks for you contribution to Ubuntu.
>
> The only change I'm not so sure about is fullscreen -> full-screen. I think
> it should probably be written "full screen" without the hyphen.
>
> Also, it would probably be best to submit this bug report and patch to Debian,
> and then let us sync it to Ubuntu, rather than carry an Ubuntu-specific delta.
> Would you be willing to do that?

Hi Barry,

I have submitted the bug and code up to debianbugs http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641675

Please let me know if I need to do anything else.

Thanks
Paul Stewart

Revision history for this message
Colin Watson (cjwatson) wrote :

That's fine, thanks. There's no need for us to carry this separately, then; spelling/grammar tweaks like this should almost always be submitted to Debian and synced/merged into Ubuntu rather than going directly through our sponsorship queue.

review: Disapprove

Unmerged revisions

78. By Paul Stewart

*Removed the libfaac-dev in the build-depends that I incorrectly copied from the medibuntu.natty control file

*Changed the uploaders and maintainer info back to what is in the ubuntu/mplayer control from

77. By Paul Stewart

*Changed the incorrect spelling of "usefule" to "useful"
*Changed incorrect spelling of "fullscreen" to "full-screen"
*Changed "abilities" to "capabilities"
*Changed "You only need these..." to "This package is required..."
*Changed instances of "mplayer" in the documentation text to a consistent "MPlayer" throughout

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2011-02-26 14:37:59 +0000
+++ debian/control 2011-08-19 18:44:26 +0000
@@ -3,9 +3,7 @@
3Priority: optional3Priority: optional
4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Debian multimedia packages maintainers <pkg-multimedia-maintainers@lists.alioth.debian.org>5XSBC-Original-Maintainer: Debian multimedia packages maintainers <pkg-multimedia-maintainers@lists.alioth.debian.org>
6Uploaders: A Mennucc1 <mennucc1@debian.org>,6Uploaders: A Mennucc1 <mennucc1@debian.org>, Reinhard Tartler <siretart@tauware.de>, Andres Mejia <mcitadel@gmail.com>
7 Reinhard Tartler <siretart@tauware.de>,
8 Andres Mejia <mcitadel@gmail.com>
9DM-Upload-Allowed: yes7DM-Upload-Allowed: yes
10Standards-Version: 3.8.48Standards-Version: 3.8.4
11Vcs-Git: git://git.debian.org/git/pkg-multimedia/mplayer.git9Vcs-Git: git://git.debian.org/git/pkg-multimedia/mplayer.git
@@ -97,11 +95,11 @@
97 DirectFB, but also SDL (plus all its drivers) and some95 DirectFB, but also SDL (plus all its drivers) and some
98 low level card-specific drivers (for Matrox, 3Dfx and Radeon, Mach6496 low level card-specific drivers (for Matrox, 3Dfx and Radeon, Mach64
99 and Permedia3). Most of them support software or hardware scaling,97 and Permedia3). Most of them support software or hardware scaling,
100 therefore allowing fullscreen display. MPlayer is also able98 therefore allowing full-screen display. MPlayer is also able
101 to use some hardware MPEG decoder boards, such as the DVB99 to use some hardware MPEG decoder boards, such as the DVB
102 and DXR3/Hollywood+.100 and DXR3/Hollywood+.
103 .101 .
104 This package includes the gui variant of mplayer.102 This package includes the GUI variant of MPlayer.
105103
106Package: mencoder104Package: mencoder
107Architecture: any105Architecture: any
@@ -122,8 +120,8 @@
122 encode MPlayer-playable movies120 encode MPlayer-playable movies
123 (AVI/ASF/OGG/DVD/VCD/VOB/MPG/MOV/VIV/FLI/RM/NUV/NET) to other121 (AVI/ASF/OGG/DVD/VCD/VOB/MPG/MOV/VIV/FLI/RM/NUV/NET) to other
124 MPlayer-playable formats. It can encode with various codecs, like DivX4122 MPlayer-playable formats. It can encode with various codecs, like DivX4
125 (1 or 2 passes), libavcodec, PCM/MP3/VBRMP3 audio. Also has stream123 (1 or 2 passes), libavcodec, PCM/MP3/VBRMP3 audio. MPlayer also has stream
126 copying and video resizing abilities.124 copying and video resizing capabilities.
127125
128Package: mplayer126Package: mplayer
129Architecture: any127Architecture: any
@@ -148,7 +146,7 @@
148 DirectFB, but also SDL (plus all its drivers) and some146 DirectFB, but also SDL (plus all its drivers) and some
149 low level card-specific drivers (for Matrox, 3Dfx and Radeon, Mach64147 low level card-specific drivers (for Matrox, 3Dfx and Radeon, Mach64
150 and Permedia3). Most of them support software or hardware scaling,148 and Permedia3). Most of them support software or hardware scaling,
151 therefore allowing fullscreen display. MPlayer is also able149 therefore allowing full-screen display. MPlayer is also able
152 to use some hardware MPEG decoder boards, such as the DVB150 to use some hardware MPEG decoder boards, such as the DVB
153 and DXR3/Hollywood+.151 and DXR3/Hollywood+.
154 .152 .
@@ -166,8 +164,8 @@
166 This package contains the debugging symbols for MPlayer, a movie164 This package contains the debugging symbols for MPlayer, a movie
167 player for Unix-like systems.165 player for Unix-like systems.
168 .166 .
169 You only need these if you want to generate usefule debugging167 This package is required if you want to generate useful debugging
170 backtraces.168 back-traces.
171169
172Package: mplayer-doc170Package: mplayer-doc
173Architecture: all171Architecture: all
@@ -179,5 +177,5 @@
179 This package contains the HTML documentation for MPlayer, a movie player for177 This package contains the HTML documentation for MPlayer, a movie player for
180 Unix-like systems. It is available in several languages.178 Unix-like systems. It is available in several languages.
181 .179 .
182 You only need this package if you want to read the mplayer manual. The manpages180 This package is required if you want to read the MPlayer manual. The manpages
183 are included in the regular mplayer package.181 are included in the regular MPlayer package.

Subscribers

People subscribed via source and target branches

to all changes: