Code review comment for lp:~paulbrianstewart/bzr/207507-bzr-commit-message

Revision history for this message
Paul Stewart (paulbrianstewart) wrote :

> Hi Paul,
>
> On 04/08/11 04:51, Paul Stewart wrote:
> > Hi Jelmer,
> >
> > If I changed the code to what I originally had, which was --message ' '
> (with the space), wouldn't that eliminate the problem/need to make bzr allow
> empty bzr commit messages? The space would technically make the message not
> empty? I don't know if that is good form, but just a thought?
> I've just submitted a branch that makes Bazaar accept empty commit
> messages if explicitly specified. Once that lands I think we could land
> your branch.
>
> See https://code.launchpad.net/~jelmer/bzr/empty-commit-message/+merge/71315
>
> Cheers,
>
> Jelmer

Excellent!..thanks Jelmer.
So do you need me to do anything els at this stage?

Thanks
Paul Stewart

« Back to merge proposal