Code review comment for lp:~paulbrianstewart/bzr/207507-bzr-commit-message

On Fri, 2011-08-05 at 10:01 +0000, John A Meinel wrote:
> On 8/4/2011 4:51 AM, Paul Stewart wrote:
> > Hi Jelmer,
> >
> > If I changed the code to what I originally had, which was --message '
> > ' (with the space), wouldn't that eliminate the problem/need to make
> > bzr allow empty bzr commit messages? The space would technically make
> > the message not empty? I don't know if that is good form, but just a
> > thought?
> >
> > What do you think?

> Yes, 'bzr commit -m " "' should work today because we get a blank space
> and not an empty commit message.
>
> I'm pretty sure we had reason to not default to allowing empty messages,
> (it *really* is hard to understand history with them), however, if
> people feel strongly we can be more flexible.
I think this was my first bazaar code patch. :) It's especially useful
if you don't use -m but bzr puts you into an editor to type the commit
message. Quitting the editor without saving is a good way of aborting
the commit.

-m "" indeed seems like a good way of saying "no, I really want to
commit with a empty commit message".

Cheers,

Jelmer