Code review comment for lp:~paulbrianstewart/bzr/207507-bzr-commit-message

On 8/4/2011 4:51 AM, Paul Stewart wrote:
> Hi Jelmer,
>
> If I changed the code to what I originally had, which was --message '
> ' (with the space), wouldn't that eliminate the problem/need to make
> bzr allow empty bzr commit messages? The space would technically make
> the message not empty? I don't know if that is good form, but just a
> thought?
>
> What do you think?
>
> Thanks Paul Stewart
>

Yes, 'bzr commit -m " "' should work today because we get a blank space
and not an empty commit message.

I'm pretty sure we had reason to not default to allowing empty messages,
(it *really* is hard to understand history with them), however, if
people feel strongly we can be more flexible.

Basically, I think our position should be that the user should
explicitly request a blank message, and 'bzr commit -m ""' seems to
cover that.

I would definitely make the warning message use "" and not '' because ''
doesn't work on Windows.

John
=:->