Code review comment for lp:~paulbrianstewart/bzr/207507-bzr-commit-message

Revision history for this message
Paul Stewart (paulbrianstewart) wrote :

Thanks Jelmer,

I'll look back over it and try to do the tests you suggest.

Thanks for your guidance and help.
Paul

> Hi Paul,
>
> Thanks for working on these papercut bugs.
>
> We have a policy in Bazaar to not use more than 80 characters per line, can
> you split the message up over multiple lines? The exception that's raised a
> couple of lines above is a good example.
>
> The quotes around the -m look a bit odd, and are inconsistent with the way we
> mention options in other places. Perhaps it would also be useful to spell out
> type long option name and mention --file as an alternative to --message.
>
> Have you tried running the test suite with these changes (./bzr selftest --no-
> plugins)? There might be a few tests that rely on the previous message.

« Back to merge proposal