Merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba

Proposed by Paul J. Lucas
Status: Merged
Approved by: Paul J. Lucas
Approved revision: 11320
Merged at revision: 11602
Proposed branch: lp:~paul-lucas/zorba/pjl-misc
Merge into: lp:zorba
Diff against target: 29 lines (+7/-2)
3 files modified
src/runtime/json/snelson.cpp (+0/-2)
test/rbkt/Queries/zorba/json/json-snelson-x2j-array-13.spec (+1/-0)
test/rbkt/Queries/zorba/json/json-snelson-x2j-array-13.xq (+6/-0)
To merge this branch: bzr merge lp:~paul-lucas/zorba/pjl-misc
Reviewer Review Type Date Requested Status
Matthias Brantner Approve
Paul J. Lucas Approve
Review via email: mp+180658@code.launchpad.net

Commit message

Removed wrong assert() for invalid XML.

Description of the change

Removed wrong assert() for invalid XML.

To post a comment you must log in.
Revision history for this message
Paul J. Lucas (paul-lucas) :
review: Approve
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue starting for the following merge proposals:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/180658

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue result for https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/180658

Stage "TestZorbaUbuntu" failed.
1 tests failed (8403 total tests run).

Check test results at http://jenkins.lambda.nu/job/TestZorbaUbuntu/228/testReport/ to view the results.

lp:~paul-lucas/zorba/pjl-misc updated
11321. By Paul J. Lucas

Fix.

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue starting for the following merge proposals:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/180658

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue succeeded - proposal merged!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/runtime/json/snelson.cpp'
2--- src/runtime/json/snelson.cpp 2013-07-29 23:55:03 +0000
3+++ src/runtime/json/snelson.cpp 2013-08-16 22:10:59 +0000
4@@ -290,8 +290,6 @@
5 parent_type = "array";
6 else if ( ::strcmp( required_name, "pair" ) == 0 )
7 parent_type = "object";
8- else
9- ZORBA_ASSERT( false );
10 throw XQUERY_EXCEPTION(
11 zerr::ZJSE0004_BAD_NODE,
12 ERROR_PARAMS( element_name, parent_type, required_name )
13
14=== added file 'test/rbkt/Queries/zorba/json/json-snelson-x2j-array-13.spec'
15--- test/rbkt/Queries/zorba/json/json-snelson-x2j-array-13.spec 1970-01-01 00:00:00 +0000
16+++ test/rbkt/Queries/zorba/json/json-snelson-x2j-array-13.spec 2013-08-16 22:10:59 +0000
17@@ -0,0 +1,1 @@
18+Error: http://zorba.io/errors:ZJSE0004
19
20=== added file 'test/rbkt/Queries/zorba/json/json-snelson-x2j-array-13.xq'
21--- test/rbkt/Queries/zorba/json/json-snelson-x2j-array-13.xq 1970-01-01 00:00:00 +0000
22+++ test/rbkt/Queries/zorba/json/json-snelson-x2j-array-13.xq 2013-08-16 22:10:59 +0000
23@@ -0,0 +1,6 @@
24+import module namespace jx = "http://zorba.io/modules/json-xml";
25+
26+let $xml := <message type="array">Hello, world!</message>
27+return jx:xml-to-json( $xml )
28+
29+(: vim:set et sw=2 ts=2: :)

Subscribers

People subscribed via source and target branches