Merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba

Proposed by Paul J. Lucas
Status: Merged
Approved by: Matthias Brantner
Approved revision: 11226
Merged at revision: 11478
Proposed branch: lp:~paul-lucas/zorba/pjl-misc
Merge into: lp:zorba
Diff against target: 27 lines (+1/-3)
2 files modified
include/zorba/time.h (+0/-1)
src/store/naive/atomic_items.cpp (+1/-2)
To merge this branch: bzr merge lp:~paul-lucas/zorba/pjl-misc
Reviewer Review Type Date Requested Status
Matthias Brantner Approve
Paul J. Lucas Approve
Review via email: mp+166109@code.launchpad.net

Commit message

Removed unncessary (and now wrong) cast.

Description of the change

Removed unncessary (and now wrong) cast.

To post a comment you must log in.
Revision history for this message
Paul J. Lucas (paul-lucas) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

The attempt to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba failed. Below is the output from the failed tests.

CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 (message):
  Validation queue job pjl-misc-2013-05-28T17-34-44.172Z is finished. The
  final status was:

  15 tests did not succeed - changes not commited.

Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job pjl-misc-2013-05-29T00-12-41.575Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 Approve.

Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job pjl-misc-2013-05-29T01-02-27.358Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'include/zorba/time.h'
--- include/zorba/time.h 2013-03-13 16:17:38 +0000
+++ include/zorba/time.h 2013-05-28 17:09:36 +0000
@@ -57,7 +57,6 @@
57 VE, ///< Vikrama Era57 VE, ///< Vikrama Era
58 VS ///< Vikrama Samvat Era58 VS ///< Vikrama Samvat Era
59 };59 };
60
61} // namespace calendar60} // namespace calendar
6261
63///////////////////////////////////////////////////////////////////////////////62///////////////////////////////////////////////////////////////////////////////
6463
=== modified file 'src/store/naive/atomic_items.cpp'
--- src/store/naive/atomic_items.cpp 2013-05-24 22:52:47 +0000
+++ src/store/naive/atomic_items.cpp 2013-05-28 17:09:36 +0000
@@ -150,10 +150,9 @@
150 case store::XS_NON_NEGATIVE_INTEGER:150 case store::XS_NON_NEGATIVE_INTEGER:
151 case store::XS_POSITIVE_INTEGER:151 case store::XS_POSITIVE_INTEGER:
152 {152 {
153 const IntegerItem* item = static_cast<const IntegerItem*>(item1);
154 try153 try
155 {154 {
156 longValue = item->getLongValue();155 longValue = item1->getLongValue();
157 GET_FACTORY().createLong(result, longValue);156 GET_FACTORY().createLong(result, longValue);
158 }157 }
159 catch (std::range_error const&)158 catch (std::range_error const&)

Subscribers

People subscribed via source and target branches