Merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba

Proposed by Paul J. Lucas
Status: Merged
Approved by: Matthias Brantner
Approved revision: 11217
Merged at revision: 11456
Proposed branch: lp:~paul-lucas/zorba/pjl-misc
Merge into: lp:zorba
Diff against target: 21 lines (+2/-2)
1 file modified
src/compiler/parser/symbol_table.cpp (+2/-2)
To merge this branch: bzr merge lp:~paul-lucas/zorba/pjl-misc
Reviewer Review Type Date Requested Status
Matthias Brantner Approve
Paul J. Lucas Approve
Review via email: mp+164062@code.launchpad.net

Commit message

I forgot to commit this file before the previous merge.

Better string-to-integer conversion exception catching -- fixes 3 FOTS tests.

Description of the change

I forgot to commit this file before the previous merge.

Better string-to-integer conversion exception catching -- fixes 3 FOTS tests.

To post a comment you must log in.
lp:~paul-lucas/zorba/pjl-misc updated
11217. By Paul J. Lucas

Merge from trunk.

Revision history for this message
Paul J. Lucas (paul-lucas) :
review: Approve
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job pjl-misc-2013-05-16T17-01-49.255Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/compiler/parser/symbol_table.cpp'
--- src/compiler/parser/symbol_table.cpp 2013-05-15 23:22:01 +0000
+++ src/compiler/parser/symbol_table.cpp 2013-05-16 02:09:27 +0000
@@ -267,7 +267,7 @@
267 try {267 try {
268 return new xs_double(text);268 return new xs_double(text);
269 }269 }
270 catch ( std::range_error const& ) {270 catch ( std::exception const& ) {
271 return NULL;271 return NULL;
272 }272 }
273}273}
@@ -277,7 +277,7 @@
277 try {277 try {
278 return new xs_integer(text);278 return new xs_integer(text);
279 }279 }
280 catch ( std::invalid_argument const& ) {280 catch ( std::exception const& ) {
281 return NULL;281 return NULL;
282 }282 }
283}283}

Subscribers

People subscribed via source and target branches