Merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba

Proposed by Paul J. Lucas
Status: Merged
Approved by: Paul J. Lucas
Approved revision: 11128
Merged at revision: 11305
Proposed branch: lp:~paul-lucas/zorba/pjl-misc
Merge into: lp:zorba
Diff against target: 75 lines (+9/-10)
4 files modified
src/runtime/durations_dates_times/format_dateTime.cpp (+1/-1)
src/runtime/full_text/thesauri/wn_types.cpp (+3/-0)
src/zorbautils/locale.cpp (+5/-6)
test/fots/CMakeLists.txt (+0/-3)
To merge this branch: bzr merge lp:~paul-lucas/zorba/pjl-misc
Reviewer Review Type Date Requested Status
Matthias Brantner Approve
Paul J. Lucas Approve
Review via email: mp+154852@code.launchpad.net

Commit message

1. Fixed typo: s/twelvth/twelfth/ -- fixed 3 FOTS failing tests.
2. Other misc. tweaks.

Description of the change

1. Fixed typo: s/twelvth/twelfth/ -- fixed 3 FOTS failing tests.
2. Other misc. tweaks.

To post a comment you must log in.
Revision history for this message
Paul J. Lucas (paul-lucas) :
review: Approve
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

The attempt to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba failed. Below is the output from the failed tests.

CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message):
  Validation queue job pjl-misc-2013-03-22T04-43-45.389Z is finished. The
  final status was:

  No tests were run - build or configure step must have failed.

  Not commiting changes.

Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job pjl-misc-2013-03-22T18-23-52.328Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/runtime/durations_dates_times/format_dateTime.cpp'
--- src/runtime/durations_dates_times/format_dateTime.cpp 2013-03-20 15:35:21 +0000
+++ src/runtime/durations_dates_times/format_dateTime.cpp 2013-03-22 04:39:23 +0000
@@ -204,7 +204,7 @@
204 { "nine", "ninth" },204 { "nine", "ninth" },
205 { "ten", "tenth" },205 { "ten", "tenth" },
206 { "eleven", "eleventh" },206 { "eleven", "eleventh" },
207 { "twelve", "twelveth" },207 { "twelve", "twelfth" },
208 { "thirteen", "thirteenth" },208 { "thirteen", "thirteenth" },
209 { "fourteen", "fourteenth" },209 { "fourteen", "fourteenth" },
210 { "fifteen", "fifteenth" },210 { "fifteen", "fifteenth" },
211211
=== modified file 'src/runtime/full_text/thesauri/wn_types.cpp'
--- src/runtime/full_text/thesauri/wn_types.cpp 2013-02-28 11:15:32 +0000
+++ src/runtime/full_text/thesauri/wn_types.cpp 2013-03-22 04:39:23 +0000
@@ -15,11 +15,14 @@
15 */15 */
16#include "stdafx.h"16#include "stdafx.h"
1717
18// standard
18#include <algorithm> /* for lower_bound */19#include <algorithm> /* for lower_bound */
1920
21// Zorba
20#include "util/less.h"22#include "util/less.h"
21#include "diagnostics/assert.h"23#include "diagnostics/assert.h"
2224
25// local
23#include "wn_types.h"26#include "wn_types.h"
2427
25using namespace std;28using namespace std;
2629
=== modified file 'src/zorbautils/locale.cpp'
--- src/zorbautils/locale.cpp 2013-03-19 14:41:54 +0000
+++ src/zorbautils/locale.cpp 2013-03-22 04:39:23 +0000
@@ -15,6 +15,10 @@
15 */15 */
16#include "stdafx.h"16#include "stdafx.h"
1717
18// standard
19#include <algorithm>
20#include <cstring>
21#include <stdexcept>
18#ifdef WIN3222#ifdef WIN32
19# include <windows.h>23# include <windows.h>
20# include "zorbautils/fatal.h"24# include "zorbautils/fatal.h"
@@ -25,13 +29,8 @@
25# include <xlocale.h> /* for newlocale(3) */29# include <xlocale.h> /* for newlocale(3) */
26#endif /* WIN32 */30#endif /* WIN32 */
2731
28#include <algorithm>32// Zorba
29#include <cstring>
30#include <stdexcept>
31
32#include <zorba/internal/unique_ptr.h>33#include <zorba/internal/unique_ptr.h>
33
34// Zorba
35#include "util/ascii_util.h"34#include "util/ascii_util.h"
36#include "util/cxx_util.h"35#include "util/cxx_util.h"
37#include "util/less.h"36#include "util/less.h"
3837
=== modified file 'test/fots/CMakeLists.txt'
--- test/fots/CMakeLists.txt 2013-03-21 21:48:52 +0000
+++ test/fots/CMakeLists.txt 2013-03-22 04:39:23 +0000
@@ -163,9 +163,6 @@
163EXPECTED_FOTS_FAILURE (fn-format-date format-date-en126 0)163EXPECTED_FOTS_FAILURE (fn-format-date format-date-en126 0)
164EXPECTED_FOTS_FAILURE (fn-format-date format-date-en127 0)164EXPECTED_FOTS_FAILURE (fn-format-date format-date-en127 0)
165EXPECTED_FOTS_FAILURE (fn-format-date format-date-en128 0)165EXPECTED_FOTS_FAILURE (fn-format-date format-date-en128 0)
166EXPECTED_FOTS_FAILURE (fn-format-date format-date-en129 0)
167EXPECTED_FOTS_FAILURE (fn-format-date format-date-en130 0)
168EXPECTED_FOTS_FAILURE (fn-format-date format-date-en131 0)
169EXPECTED_FOTS_FAILURE (fn-format-date format-date-en132 0)166EXPECTED_FOTS_FAILURE (fn-format-date format-date-en132 0)
170EXPECTED_FOTS_FAILURE (fn-format-date format-date-en133 0)167EXPECTED_FOTS_FAILURE (fn-format-date format-date-en133 0)
171EXPECTED_FOTS_FAILURE (fn-format-date format-date-en134 0)168EXPECTED_FOTS_FAILURE (fn-format-date format-date-en134 0)

Subscribers

People subscribed via source and target branches