Merge lp:~patrickas/ensoft-sextant/python3 into lp:ensoft-sextant

Proposed by Patrick Stevens
Status: Merged
Approved by: Patrick Stevens
Approved revision: 6
Merged at revision: 5
Proposed branch: lp:~patrickas/ensoft-sextant/python3
Merge into: lp:ensoft-sextant
Diff against target: 32 lines (+8/-3)
2 files modified
src/sextant/__main__.py (+6/-1)
src/sextant/query.py (+2/-2)
To merge this branch: bzr merge lp:~patrickas/ensoft-sextant/python3
Reviewer Review Type Date Requested Status
Patrick Stevens Approve
Review via email: mp+231217@code.launchpad.net

Commit message

Make Sextant Web fail gracefully if we attempt to run it under Python 3.

Description of the change

Make Sextant Web fail gracefully if we attempt to run it under Python 3. Now all of Sextant runs under Python 3 without causing any Python 2-related errors.

To post a comment you must log in.
lp:~patrickas/ensoft-sextant/python3 updated
5. By Patrick Stevens <email address hidden>

Use logging instead of print for errors

6. By Patrick Stevens <email address hidden>

Merge minor bugfixes branch

Revision history for this message
Patrick Stevens (patrickas) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/sextant/__main__.py'
--- src/sextant/__main__.py 2014-08-15 10:49:08 +0000
+++ src/sextant/__main__.py 2014-08-19 09:13:40 +0000
@@ -153,7 +153,12 @@
153def _start_web(args):153def _start_web(args):
154 # Don't import at top level -- this makes twisted dependency semi-optional,154 # Don't import at top level -- this makes twisted dependency semi-optional,
155 # allowing non-web functionality to work with Python 3.155 # allowing non-web functionality to work with Python 3.
156 from .web import server156 try:
157 from .web import server
158 except ImportError as e: # twisted wasn't available - Python 2
159 log.error('Web server must be run on Python 2.')
160 log.error(e)
161 return
157 log.info("Serving site on port %s", args.port)162 log.info("Serving site on port %s", args.port)
158 server.serve_site(input_database_url=args.remote_neo4j, port=args.port)163 server.serve_site(input_database_url=args.remote_neo4j, port=args.port)
159164
160165
=== modified file 'src/sextant/query.py'
--- src/sextant/query.py 2014-08-11 15:14:05 +0000
+++ src/sextant/query.py 2014-08-19 09:13:40 +0000
@@ -18,8 +18,8 @@
18 try:18 try:
19 db = db_api.SextantConnection(remote_neo4j)19 db = db_api.SextantConnection(remote_neo4j)
20 except requests.exceptions.ConnectionError as err:20 except requests.exceptions.ConnectionError as err:
21 logging.exception("Could not connect to Neo4J server {}. Are you sure it is running?".format(remote_neo4j))21 logging.error("Could not connect to Neo4J server {}. Are you sure it is running?".format(remote_neo4j))
22 logging.exception(str(err))22 logging.error(str(err))
23 return 223 return 2
24 #Not supported in python 224 #Not supported in python 2
25 #except (urllib.exceptions.MaxRetryError):25 #except (urllib.exceptions.MaxRetryError):

Subscribers

People subscribed via source and target branches