Code review comment for lp:~patrick-regan/bzr/ignoreclarify

Revision history for this message
Patrick Regan (patrick-regan) wrote :

My only concern with getting rid of the

"The ignore command will also automatically add the .bzrignore file to be versioned."

sentence is that the original bug complaint was the following:

"From observation of behaviour, not by reading code, it is apparent that 'ignore' creates a .bzrignore file if none exists, or appends to it if it exists already. That might be expected. 'ignore' ALSO does an implicit and silent ADD of .bzrignore to the versioned file set. That was not entirely expected, and the tutorial is misleading in this respect."

I added that sentence to specifically mention that it does do a silent ADD. Do you think that the mentioning of this implicit add in the tutorial is enough? I've since changed the other suggestions in my local branch.

« Back to merge proposal