Code review comment for lp:~patrick-hetu/charms/precise/python-django/charmhelpers

Greetings Patrick,

Looks like progress has continued to land on the Python-Django charm. I've taken the liberty of reviewing the most recent revision and I have the following notes:

There is a proof error:
W: config.yaml: option django_uid does not have the keys: description
W: config.yaml: option django_gid does not have the keys: description

and I also ran into some troubles with the included integration tests. Attaching tracebacks:

2014-09-08 21:05:12,160 INFO Unavailable, retrying: http://ec2-54-167-142-245.compute-1.amazonaws.com:8080/
ERROR

======================================================================
ERROR: setUpModule (__main__)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/10-postgresql", line 36, in setUpModule
    attempts=10, retry_unavailable=True)
  File "/home/ubuntu/charms/precise/python-django/tests/helpers/__init__.py", line 51, in check_url
    sys.stdout.flush()
BrokenPipeError: [Errno 32] Broken pipe

----------------------------------------------------------------------
Ran 0 tests in 679.730s

FAILED (errors=1)
Exception ignored in: <_io.TextIOWrapper name='<stdout>' mode='w' encoding='ANSI_X3.4-1968'>
BrokenPipeError: [Errno 32] Broken pipe
2014-09-08 21:05:55,425 INFO Unavailable, retrying: http://ec2-54-234-57-45.compute-1.amazonaws.com:8080/
ERROR

======================================================================
ERROR: test_app (01-versions.LandscapeServiceTests)
Verify that the APP service is up.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/01-versions", line 58, in test_app
    attempts=10, retry_unavailable=True)
  File "/home/ubuntu/charms/precise/python-django/tests/helpers/__init__.py", line 51, in check_url
    sys.stdout.flush()
BrokenPipeError: [Errno 32] Broken pipe

----------------------------------------------------------------------
Ran 1 test in 1558.975s

FAILED (errors=1)
Exception ignored in: <_io.TextIOWrapper name='<stdout>' mode='w' encoding='ANSI_X3.4-1968'>
BrokenPipeError: [Errno 32] Broken pipe

Thanks again for the submission, I look forward to the next iteration and progress!