Merge lp:~patrick-crews/drizzle/dbqp_freebsd_ports into lp:drizzle/7.0

Proposed by Patrick Crews
Status: Merged
Approved by: Lee Bieber
Approved revision: 2122
Merged at revision: 2123
Proposed branch: lp:~patrick-crews/drizzle/dbqp_freebsd_ports
Merge into: lp:drizzle/7.0
Diff against target: 33 lines (+11/-1)
2 files modified
tests/lib/sys_mgmt/port_management.py (+10/-1)
tests/lib/sys_mgmt/system_management.py (+1/-0)
To merge this branch: bzr merge lp:~patrick-crews/drizzle/dbqp_freebsd_ports
Reviewer Review Type Date Requested Status
Drizzle Developers Pending
Review via email: mp+47724@code.launchpad.net

Description of the change

Fixes how we parse netstat output during port allocation checks.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/lib/sys_mgmt/port_management.py'
--- tests/lib/sys_mgmt/port_management.py 2011-01-21 18:47:56 +0000
+++ tests/lib/sys_mgmt/port_management.py 2011-01-27 20:39:58 +0000
@@ -107,7 +107,16 @@
107 if entry.startswith('Proto'):107 if entry.startswith('Proto'):
108 good_data = 1108 good_data = 1
109 elif good_data:109 elif good_data:
110 used_port = int(entry.split()[3].split(':')[-1].strip())110 # We try to catch additional output
111 # like we see with freebsd
112 if entry.startswith('Active'):
113 good_data = 0
114 pass
115 else:
116 if self.system_manager.cur_os == 'FreeBSD':
117 used_port = int(entry.split()[3].split('.')[-1].strip())
118 else:
119 used_port = int(entry.split()[3].split(':')[-1].strip())
111 if port == used_port:120 if port == used_port:
112 if entry.split()[-1] != "TIME_WAIT":121 if entry.split()[-1] != "TIME_WAIT":
113 return 1122 return 1
114123
=== modified file 'tests/lib/sys_mgmt/system_management.py'
--- tests/lib/sys_mgmt/system_management.py 2011-01-26 01:13:20 +0000
+++ tests/lib/sys_mgmt/system_management.py 2011-01-27 20:39:58 +0000
@@ -49,6 +49,7 @@
49 self.env_var_delimiter = ':'49 self.env_var_delimiter = ':'
50 self.no_shm = variables['noshm']50 self.no_shm = variables['noshm']
51 self.shm_path = self.find_path(["/dev/shm", "/tmp"], required=0)51 self.shm_path = self.find_path(["/dev/shm", "/tmp"], required=0)
52 self.cur_os = os.uname()[0]
52 self.symlink_name = 'dtr_work_sym'53 self.symlink_name = 'dtr_work_sym'
53 self.workdir = variables['workdir']54 self.workdir = variables['workdir']
54 self.start_dirty = variables['startdirty']55 self.start_dirty = variables['startdirty']

Subscribers

People subscribed via source and target branches