Code review comment for lp:~parthm/bzr/503670-vila-grep-as-builtin

Revision history for this message
Robert Collins (lifeless) wrote :

 review: needsfixing

So this seems to have very few tests and not work on windows. I don't
think its good enough to merge to core yet.

Also as this doesn't look in history at all, there is really little
benefit in putting it in the core unless its going to make windows users
lives easier (which it won't). Right now its little more than 'bzr ls |
xargs greap'.

I rather suspect you'd be better of writing one from scratch with full
tests at appropriate unit and blackbox layers, to get windows support
and test coverage.

-Rob

review: Needs Fixing

« Back to merge proposal