Code review comment for lp:~parthm/bzr/430785-clean-tree-oserror-warning
Revision history for this message
| Parth Malwankar (parthm) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> I'm fairly ok with the concept, but I have to wonder why we are trying
> to delete something that is still open? Sounds like a user mistake, one
> that they probably would regret (since this open file could have been
> deleted).
>
Yes, bzr trying to delete the spreadsheet in the above example could possibly be due to a user mistake. As bzr list the files and ask for confirmation before actually deleting I think its not too easy for a user mistake to pass through.
Alternatively, we could show a better error message than WindowsError and exit but a warning may be nicer in some situations. Specifically, in the case outlined by the reporter in the bug report a warning seems to be a good option (quote):
(In my case my development project is big and loading the projects into my dev tool takes some time. Unfortunately my dev tool is locking one single file, which prevents me from cleaning the tree, unless a close my dev environment.)