Code review comment for lp:~parthm/bzr/376388-dot-bazaar-ownership-regression-2.2

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
>>> There is one specific case which requires that the ownership gets copied
>> from the containing directory. If the config file doesn't exist and is created
>> by bzr under sudo we need to be sure that the user has ownership.
>>
>> That is true, but if the file already exists, shouldn't we use the
>> permissions it already has?
>
> The patch is about ownership of the file not about its permissions. atomicfile preserve existing permissions right ?
>

Well, shouldn't we use the *ownership* it already has? (yes you are
right that AF preserves permissions.)

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkxGFxQACgkQJdeBCYSNAAMbOACgnu6fZTi9i02xG9R0ik27KPAm
BoIAoJgNO0KpmnIaAeF7X1EVwLPEBkV2
=sFss
-----END PGP SIGNATURE-----