Code review comment for lp:~parthm/bzr/376388-dot-bazaar-ownership-regression-2.2

Revision history for this message
Vincent Ladeuil (vila) wrote :

> > There is one specific case which requires that the ownership gets copied
> from the containing directory. If the config file doesn't exist and is created
> by bzr under sudo we need to be sure that the user has ownership.
>
> That is true, but if the file already exists, shouldn't we use the
> permissions it already has?

The patch is about ownership of the file not about its permissions. atomicfile preserve existing permissions right ?

« Back to merge proposal