Code review comment for lp:~parthm/bzr/376388-dot-bazaar-ownership-regression-2.2

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Parth Malwankar wrote:
> Thanks for the review John.
>
>> Is this really what we want to do? It looks like we grab the info for the file
>> from its containing directory. I think what we would really want is to have
>> the permissions be obtained from the file that is being replaced.
>>
>
> There is one specific case which requires that the ownership gets copied from the containing directory. If the config file doesn't exist and is created by bzr under sudo we need to be sure that the user has ownership.

That is true, but if the file already exists, shouldn't we use the
permissions it already has?

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkxFy8QACgkQJdeBCYSNAAO8PQCcDpwk6fEc3MMCS7NQS3XkoMah
pl0An3s5gtO13PdV9AIFsrF+JvR3CYnr
=dFGi
-----END PGP SIGNATURE-----