Code review comment for lp:~parthm/bzr/376388-dot-bazaar-ownership-regression-2.2
Revision history for this message
| Vincent Ladeuil (vila) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Is this really what we want to do?
It's what we did before.
> It looks like we grab the info for the file
> from its containing directory. I think what we would really want is to have
> the permissions be obtained from the file that is being replaced.
Isn't atomicfile ensuring the permissions are preserved ?
copy_ownership only applies when running as root anyway...