Code review comment for lp:~parthm/bzr/376388-dot-bazaar-ownership-regression-2.2
Revision history for this message
| Parth Malwankar (parthm) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Thanks for the review John.
> Is this really what we want to do? It looks like we grab the info for the file
> from its containing directory. I think what we would really want is to have
> the permissions be obtained from the file that is being replaced.
>
There is one specific case which requires that the ownership gets copied from the containing directory. If the config file doesn't exist and is created by bzr under sudo we need to be sure that the user has ownership.
> Which would hint to a fix in AtomicFile itself, possibly with an optional
> flag.