Code review comment for lp:~parthm/bzr/376388-dot-bazaar-ownership-regression-2.2

Revision history for this message
John A Meinel (jameinel) wrote :

Is this really what we want to do? It looks like we grab the info for the file from its containing directory. I think what we would really want is to have the permissions be obtained from the file that is being replaced.

Which would hint to a fix in AtomicFile itself, possibly with an optional flag.

review: Needs Fixing

« Back to merge proposal