Code review comment for lp:~parthm/bzr/300062-bad-pattern-error-part-1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Parth Malwankar wrote:
> sent to pqm by email
>

Failing in PQM with:

======================================================================
ERROR: bzrlib.tests.test_globbing.TestGlobster.test_bad_pattern
- ----------------------------------------------------------------------
_StringException: Text attachment: log
- ------------

- ------------
Text attachment: traceback
- ------------
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/testtools/runtest.py", line
128, in _run_user
    return fn(*args)
  File "/usr/lib/python2.4/site-packages/testtools/testcase.py", line
368, in _run_test_method
    testMethod()
  File
"/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/test_globbing.py",
line 316, in test_bad
pattern
    e = self.assertRaises(errors.InvalidPattern, g.match, 'foo')
  File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/__init__.py",
line 1249, in assertRaises
    callableObj(*args, **kwargs)
  File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/globbing.py", line
219, in match
    except errors.InvalidPattern, e:
  File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/lazy_import.py",
line 106, in __getattribute__
    obj = _replace()
  File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/lazy_import.py",
line 88, in _replace
    extra=e)
IllegalUseOfScopeReplacer: ScopeReplacer object 'errors' was used
incorrectly: Object already clean
d up, did you assign it to another variable?: _factory
- ------------

======================================================================
ERROR: bzrlib.tests.test_osutils.TestReCompile.test_re_compile_checked
- ----------------------------------------------------------------------
_StringException: Text attachment: log
- ------------
4178.727 Deprecated function called
Called from:
  File "/usr/lib/python2.4/site-packages/testtools/runtest.py", line
128, in _run_user
    return fn(*args)
  File "/usr/lib/python2.4/site-packages/testtools/testcase.py", line
368, in _run_test_method
    testMethod()
  File
"/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/test_osutils.py",
line 1709, in test_re_
ompile_checked
    r = osutils.re_compile_checked(r'A*', re.IGNORECASE)
  File
"/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/symbol_versioning.py",
line 95, in decorated_f
nction
    trace.mutter_callsite(4, "Deprecated function called")
- ------------
Text attachment: traceback
- ------------
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/testtools/runtest.py", line
128, in _run_user
    return fn(*args)
  File "/usr/lib/python2.4/site-packages/testtools/testcase.py", line
368, in _run_test_method
    testMethod()
  File
"/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/test_osutils.py",
line 1709, in test_re_
ompile_checked
    r = osutils.re_compile_checked(r'A*', re.IGNORECASE)
  File
"/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/symbol_versioning.py",
line 97, in decorated_f
nction
    DeprecationWarning, stacklevel=2)
  File "/usr/lib/python2.4/warnings.py", line 61, in warn
    warn_explicit(message, category, filename, lineno, module, registry)
  File "/usr/lib/python2.4/warnings.py", line 96, in warn_explicit
    raise message
DeprecationWarning: bzrlib.osutils.re_compile_checked was deprecated in
version 2.2.0.
- ------------

======================================================================
ERROR: bzrlib.tests.test_osutils.TestReCompile.test_re_compile_checked_error
- ----------------------------------------------------------------------
_StringException: Text attachment: log
- ------------
4178.742 Deprecated function called
Called from:
  File "/usr/lib/python2.4/site-packages/testtools/testcase.py", line
368, in _run_test_method
    testMethod()
  File
"/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/test_osutils.py",
line 1717, in test_re_
ompile_checked_error
    osutils.re_compile_checked, '*', re.IGNORECASE, 'test case')
  File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/__init__.py",
line 1249, in assertRaises
    callableObj(*args, **kwargs)
  File
"/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/symbol_versioning.py",
line 95, in decorated_f
nction
    trace.mutter_callsite(4, "Deprecated function called")
- ------------
Text attachment: traceback
- ------------
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/testtools/runtest.py", line
128, in _run_user
    return fn(*args)
  File "/usr/lib/python2.4/site-packages/testtools/testcase.py", line
368, in _run_test_method
    testMethod()
  File
"/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/test_osutils.py",
line 1717, in test_re_
ompile_checked_error
    osutils.re_compile_checked, '*', re.IGNORECASE, 'test case')
  File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/__init__.py",
line 1249, in assertRaises
    callableObj(*args, **kwargs)
  File
"/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/symbol_versioning.py",
line 97, in decorated_f
nction
    DeprecationWarning, stacklevel=2)
  File "/usr/lib/python2.4/warnings.py", line 61, in warn
    warn_explicit(message, category, filename, lineno, module, registry)
  File "/usr/lib/python2.4/warnings.py", line 96, in warn_explicit
    raise message
DeprecationWarning: bzrlib.osutils.re_compile_checked was deprecated in
version 2.2.0.
- ------------

- ----------------------------------------------------------------------
Ran 46 tests in 6.367s

FAILED (errors=3)

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkw1/awACgkQJdeBCYSNAAPqHQCgwVHkavqAhnyxsFLN3iD8Mzii
4msAoIpATmcFr7jj+wmIWcAFrySvYgar
=2foY
-----END PGP SIGNATURE-----