Code review comment for lp:~parthm/bzr/250451-better-url-for-break-lock

Revision history for this message
Parth Malwankar (parthm) wrote :

> Excellent !
>
> One nit though so my vote is really Tweak (needs fixing but Approve if
> addressed and doesn't need another review):
>
> 66 + if lock_url.startswith('file://'):
> 67 + lock_url = lock_url.split('.bzr/')[0] + '\n'
>
> 96 + raise LockContention('(local)', lock_url.rstrip())
>
> is a bit ugly, there should be a way to not add this '\n' instead so you don't
> have to remove it later. This '\n' is not part of the url anyway.
>

Yes. That was a little ugly. I was not too happy with it myself.
I had set it up that way to allow a line-break in case the url is printed. I have removed that now and rely on the terminal to wrap the text.

> Not a big deal but I find it harder to read.

« Back to merge proposal