Code review comment for lp:~parnold-x/slingshot/conversion-plugin

Revision history for this message
Djax (parnold-x) wrote :

The other plugins are just imported from synapse, so no need to adapt to their code style.
Ah yeah, my "funny" country uses 1,3 but it is easy to fix.
"1.3 meters to yards". The match_regex splits just at " to " with no digit before the whitespace. So no problem with what digit is used.
In the temperature case there was a problem to match the digit in that case but I fixed that also.

« Back to merge proposal