Code review comment for lp:~parnold-x/slingshot/conversion-plugin
Revision history for this message
| Jacob Parker (jacobparker1992) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Don't kill me, but I changed the code style once again to match the other files in the plugins directory (which is apparently different to the elementary code style :P).
How are digits handled? We pick up '1.3 meters to yards', but I don't think we handle the funny countries that would write '1,3' instead. I'm not sure why we pick up '1.3' though---is that somehow part of the digit regex (JS considers \d to only be 0-9)?
- Jacob