Code review comment for ~paride/ubuntu/+source/simplestreams:simplestreams-sru-lp1908452-focal

Revision history for this message
dann frazier (dannf) wrote :

Code looks good to me - however we'll need to also uploads for hirsute and groovy so that an upgrade is not a regression. That means we'll probably need to use a different version string for focal. I'd suggest the following stringe for hirsute, groovy and focal - respectively:

0.1.0-30-g3cc8988a-0ubuntu1.21.04.1
0.1.0-30-g3cc8988a-0ubuntu1.20.10.1
0.1.0-30-g3cc8988a-0ubuntu1.20.04.1

or, alternatively, if you'd like to treat it like a backport:

0.1.0-30-g3cc8988a-0ubuntu1.1 (hirsute)
0.1.0-30-g3cc8988a-0ubuntu1.1~20.10.1 (groovy)
0.1.0-30-g3cc8988a-0ubuntu1.1~20.04.1 (focal)
In this case, I'd suggest keeping the hirsute changelog entry in both the groovy/focal changelogs, but adding a new "Backport to {groovy, focal}" entry on top for the backport targets.

review: Needs Fixing

« Back to merge proposal