Merge lp:~paride/ubuntu-cdimage/ubuntu-cdimage into lp:ubuntu-cdimage

Proposed by Paride Legovini
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: no longer in the source branch.
Merged at revision: 1926
Proposed branch: lp:~paride/ubuntu-cdimage/ubuntu-cdimage
Merge into: lp:ubuntu-cdimage
Diff against target: 17 lines (+5/-2)
1 file modified
lib/cdimage/tree.py (+5/-2)
To merge this branch: bzr merge lp:~paride/ubuntu-cdimage/ubuntu-cdimage
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Review via email: mp+397422@code.launchpad.net

Commit message

live-server: bump the OVERSIZED limit for >= Focal

Image size bump due to the HWE kernel inclusion in the images.

To post a comment you must log in.
Revision history for this message
Paride Legovini (paride) wrote :

I mounted the ISOs and verified that the issue is actually with the now included HWE kernel files in /casper and /pool.

The image size is still DVD-safe.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

11:53 < sil2100> paride: hm, ok, I think it makes sense - of course we only have the HWE kernels for focal, not in groovy or hirsute, so it's not really >= focal - but that being said, I think a size bump of this magnitude is okay anyway

So +1.

review: Approve
1926. By Łukasz Zemczak

live-server: bump the OVERSIZED limit for >= Focal

Image size bump due to the HWE kernel inclusion in the images.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/cdimage/tree.py'
--- lib/cdimage/tree.py 2020-12-10 17:32:42 +0000
+++ lib/cdimage/tree.py 2021-02-03 10:35:39 +0000
@@ -1874,8 +1874,11 @@
1874 # https://irclogs.ubuntu.com/2016/10/01/%23ubuntu-release.html#t19:061874 # https://irclogs.ubuntu.com/2016/10/01/%23ubuntu-release.html#t19:06
1875 return 1024 * 1024 * 10241875 return 1024 * 1024 * 1024
1876 elif self.project == "ubuntu-server":1876 elif self.project == "ubuntu-server":
1877 # email with powersj, 202001081877 if self.config["DIST"] >= "focal":
1878 if self.config["DIST"] >= "bionic":1878 # Size bump due to HWE kernel inclusion in the images
1879 return 1.3 * 1000 * 1000 * 1000
1880 elif self.config["DIST"] >= "bionic":
1881 # email with powersj, 20200108
1879 return 1.2 * 1000 * 1000 * 10001882 return 1.2 * 1000 * 1000 * 1000
1880 elif self.config["DIST"] >= "xenial":1883 elif self.config["DIST"] >= "xenial":
1881 return 1024 * 1024 * 10241884 return 1024 * 1024 * 1024

Subscribers

People subscribed via source and target branches