Merge ~paride/autopkgtest-cloud:userdata-new-cycle into autopkgtest-cloud:master

[Paride Legovini]

armhf: handle case where devel release images are missing

[Brian Murray (brian-murray)]

Does autopkgtest-build-lxd-ubuntu do some magic with the $RELEASE variable e.g. editing /etc/apt/sources.list?

review: Needs Information

[Brian Murray (brian-murray)]

review: Approve

[Paride Legovini (paride)]

Updated reference in comment as discussed in side channel.

diff --git a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd.userdata b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd.userdata
index e64eb8f..440b2e4 100644
--- a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd.userdata
+++ b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd.userdata
@@ -100,7 +100,13 @@ write_files:
      systemctl stop snap.lxd.daemon.unix.socket snap.lxd.daemon.service || true
      systemctl start snap.lxd.daemon.unix.socket snap.lxd.daemon.service
      lxd init --preseed < /var/tmp/setup/lxd-init
-     /home/ubuntu/autopkgtest/tools/autopkgtest-build-lxd ubuntu-daily:$(distro-info --devel)/armhf
+     if lxc image info ubuntu-daily:$(distro-info --devel)/armhf >/dev/null 2>&1; then
+         /home/ubuntu/autopkgtest/tools/autopkgtest-build-lxd ubuntu-daily:$(distro-info --devel)/armhf
+     else
+         # if image for the devel release does not exist then take the latest stable release and upgrade it.
+         # see autopkgtest-build-lxd(1) on what the RELEASE environment variable does.
+         MIRROR=http://ftpmaster.internal/ubuntu/ RELEASE=$(distro-info --devel) /home/ubuntu/autopkgtest/tools/autopkgtest-build-lxd ubuntu:$(distro-info --stable)/armhf
+     fi
      for r in $({ distro-info --supported; distro-info --supported-esm; } | sort -u | grep -v "$(distro-info --devel)\|trusty"); do /home/ubuntu/autopkgtest/tools/autopkgtest-build-lxd ubuntu:$r/armhf; done
      echo "Finished building - rebooting so changed kernel command line comes into effect..."
      reboot