Code review comment for ~pappacena/launchpad:change-override-log

Revision history for this message
Colin Watson (cjwatson) wrote :

This looks like broadly the right sort of direction. The main thing that I think needs to change is to explicitly pass the principal down from the caller (using @call_with(user=REQUEST_USER) or similar in the interface declaration) rather than picking out the principal in model code.

« Back to merge proposal