Code review comment for lp:~paolorotolo/ubuntu-clock-app/search-button
Revision history for this message
| Nekhelesh Ramananthan (nik90) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
As mentioned during our conversation on IRC, I wanted to add some more modifications to your MP instead of creating a new MP myself. You can see the code changes that need to be done at http://
The result of that is http://
The code changes do the following,
- Reduces the size of the magnifier icon (pointed out by the designer during my chat with him)
- Changes the anchoring of the searchLabel and searchButton such that they span the entire width of the app. I also tested it on the desktop and it looks good.
That's pretty much. Merge this in to your branch and we are good to merge your MP into trunk.