Ubuntu Clock App

Code review comment for lp:~paolorotolo/ubuntu-clock-app/search-button

  1. search-button
  2. Merge into saucy
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

The overall implementation looks good now. Just need some very minor fixes.

1. Try reducing the width of the button
2. Remove the anchors.leftMargin: units.gu(1) to bring it closer to the search field as shown in the design.

Atm we are ignoring the flat edge as shown in the design since I am not sure how to implement that. One way would be replacing the Button with an Image, but then you would not get the indent effect that you get when you press a button.

review: Needs Fixing

« Back to merge proposal