Code review comment for lp:~paolorotolo/ubuntu-clock-app/fix-for-1200410

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

You missed the restart() part I mentioned earlier.

"Looking at the docs here at http://harmattan-dev.nokia.com/docs/library/html/qt4/qml-timer.html#restart-method, it seems that restart() alone will do the job. If the timer has not started, restart will start it. If the timer is running, it will stop, reset and then start the timer. Hence I think you can remove the start()."

review: Needs Fixing

« Back to merge proposal