Code review comment for lp:~paolorotolo/ubuntu-clock-app/fix-for-1200410

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Looking at the docs here at http://harmattan-dev.nokia.com/docs/library/html/qt4/qml-timer.html#restart-method, it seems that restart() alone will do the job. If the timer has not started, restart will start it. If the timer is running, it will stop, reset and then start the timer. Hence I think you can remove the start().

Also can you reduce the interval to 1100. 1300 seems to be a bit slow. Again this is a sensitive variable. Hence we can fine tune it at a later stage as well.

A small nitpick, can you align the comment code to the Timer {} and not the row.

review: Needs Fixing

« Back to merge proposal