Code review comment for ~paelzer/ubuntu/+source/virt-manager:merge-2.2.1-4-groovy

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

# CHECKLIST
----------------------------
 [.] changelog entry correct:
 [.] targeted to correct codename
 [.] version number is correct
 [.] update-maintainer has been run before
 ----
 [-] changes forwarded upstream/debian (if appropriate)
 [-] patches match what was proposed upstream
 ----
 [.] patches correctly included in debian/patches/series?
 [.] patches have correct DEP3 metadata
 ----
 [-] relying on PPA only for build check ?
 [-] if relying on PPA, did it install correctly ?
 ----
 [.] building it locally ?
 [.] if building locally, was source build good ?
 [.] if building locally, was binary build good ?
 ----
 [-] was autopkgtest tested ?
 ----
 [-] is this a SRU ?
 [-] if a SRU, does the public bug have a template ?
 [-] is this a bundle of fixes ?
 [-] is this a single fix ?
 ----
 [-] if single fix, was testcase provided ?
 [-] if single fix, and testcase provided, could I reproduce it ?
 [-] if single fix, and testcase provided, did it work ?
 ----
 [.] is this a MERGE ?
 [-] if MERGE, is there a public bug referred ?
 [-] if MERGE, does it add/remove existing packages ?
 [-] if MERGE, does it bump library SONAME ?
----------------------------
 [.] = ok | [x] = not ok | [?] = question | [!] = note | [-] = n/a
----------------------------
# changelog:

  * Merge with Debian unstable. Remaining changes:
    - d/p/mark-libvirt-lxc: Clearly mark the LXC connections as being
      libvirt-lxc, to avoid confusion due to differing features and
      configurations.
      [accepted upstream, but not yet released)
    - Fix legacy-images path for focal. LP: 1872941
      [updated patch headers with upstream status]
  * Dropped changes:
    - Depend on gir1.2-appindicator3-0.1 for appindicator support.
      [accepted in Debian 1:2.2.1-4]

# files touched:

 /debian/patches/legacy-images.patch | 28 ++++
 b/debian/changelog | 15 ++
 b/debian/control | 3
 b/debian/patches/legacy-images.patch | 5
 b/debian/patches/mark-libvirt-lxc.patch | 29 ++++
 b/debian/patches/series | 1
 debian/changelog | 375 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 debian/patches/series | 1
 8 files changed, 456 insertions(+), 1 deletion(-)

# extra:

dpkg-deb: building package 'virtinst' in '../virtinst_2.2.1-4ubuntu1_all.deb'.
dpkg-deb: building package 'virt-manager' in '../virt-manager_2.2.1-4ubuntu1_all.deb'.

upgrade:

$ sudo dpkg -i virtinst_2.2.1-4ubuntu1_all.deb virt-manager_2.2.1-4ubuntu1_all.deb
(Reading database ... 124894 files and directories currently installed.)
Preparing to unpack virtinst_2.2.1-4ubuntu1_all.deb ...
Unpacking virtinst (1:2.2.1-4ubuntu1) over (1:2.2.1-3ubuntu2) ...
Preparing to unpack virt-manager_2.2.1-4ubuntu1_all.deb ...
Unpacking virt-manager (1:2.2.1-4ubuntu1) over (1:2.2.1-3ubuntu2) ...
Setting up virtinst (1:2.2.1-4ubuntu1) ...
Setting up virt-manager (1:2.2.1-4ubuntu1) ...

installation:

$ sudo dpkg -i virtinst_2.2.1-4ubuntu1_all.deb virt-manager_2.2.1-4ubuntu1_all.deb
Selecting previously unselected package virtinst.
(Reading database ... 124591 files and directories currently installed.)
Preparing to unpack virtinst_2.2.1-4ubuntu1_all.deb ...
Unpacking virtinst (1:2.2.1-4ubuntu1) ...
Selecting previously unselected package virt-manager.
Preparing to unpack virt-manager_2.2.1-4ubuntu1_all.deb ...
Unpacking virt-manager (1:2.2.1-4ubuntu1) ...
Setting up virtinst (1:2.2.1-4ubuntu1) ...
Setting up virt-manager (1:2.2.1-4ubuntu1) ...

+1

----

review: Approve

« Back to merge proposal