Merge ~paelzer/ubuntu/+source/spice:merge-0.14.3-2-HIRSUTE into ubuntu/+source/spice:debian/sid

Proposed by Christian Ehrhardt 
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: 801aab6ac7946f7c23199c538e80015d7cd37312
Merge reported by: Christian Ehrhardt 
Merged at revision: 801aab6ac7946f7c23199c538e80015d7cd37312
Proposed branch: ~paelzer/ubuntu/+source/spice:merge-0.14.3-2-HIRSUTE
Merge into: ubuntu/+source/spice:debian/sid
Diff against target: 230 lines (+171/-2)
2 files modified
debian/changelog (+168/-0)
debian/control (+3/-2)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior (community) Approve
Canonical Server Pending
git-ubuntu developers Pending
Review via email: mp+393251@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Merge tags:
To ssh://git.launchpad.net/~paelzer/ubuntu/+source/spice
 * [new tag] lp9999999/logical/0.14.3-1ubuntu2 -> lp9999999/logical/0.14.3-1ubuntu2
 * [new tag] lp9999999/new/debian -> lp9999999/new/debian
 * [new tag] lp9999999/old/debian -> lp9999999/old/debian
 * [new tag] lp9999999/old/ubuntu -> lp9999999/old/ubuntu
 * [new tag] lp9999999/reconstruct/0.14.3-1ubuntu2 -> lp9999999/reconstruct/0.14.3-1ubuntu2
 * [new tag] lp9999999/split/0.14.3-1ubuntu2 -> lp9999999/split/0.14.3-1ubuntu2

This is mostly dropping changes (as Debian accepted them).
One remains (universe, no MIR wanted).
On that remaining delta I have improved the situation a bit by at least leaving a suggests to help users.

But overall this should be a trivial MP.

PPA: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4324/+packages

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

I'll take this one.

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

* Changelog:
  - [√] old content and logical tag match as expected
  - [√] changelog entry correct version and targeted codename
  - [√] changelog entries correct
  - [√] update-maintainer has been run

* Actual changes:
  - [√] no upstream changes to consider
  - [√] no further upstream version to consider
  - [√] debian changes look safe

* Old Delta:
  - [√] dropped changes are ok to be dropped
  - [√] nothing else to drop
  - [√] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [√] no new patches added
  - [-] patches match what was proposed upstream
  - [-] patches correctly included in debian/patches/series
  - [-] patches have correct DEP3 metadata

* Build/Test:
  - [√] build is ok
  - [√] verified PPA package installs/uninstalls
  - [√] autopkgtest against the PPA package passes
  - [√] sanity checks test fine

Thanks for the MP, Christian.

Everything looks good. I built a local version of the patch successfully, installed it and everything worked OK.

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks also LGTM ... uploading

To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/spice
 * [new tag] upload/0.14.3-2ubuntu1 -> upload/0.14.3-2ubuntu1

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading spice_0.14.3-2ubuntu1.dsc: done.
  Uploading spice_0.14.3-2ubuntu1.debian.tar.xz: done.
  Uploading spice_0.14.3-2ubuntu1_source.buildinfo: done.
  Uploading spice_0.14.3-2ubuntu1_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This is in hirsute

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 8a23c9b..cb0d5a6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
1spice (0.14.3-2ubuntu1) hirsute; urgency=medium
2
3 * Merge with Debian unstable (LP: #9999999). Remaining changes:
4 - d/control: Don't recommend -libav gstreamer plugins since it is in
5 universe. This now downgrades it to a suggest instead of completely
6 removing the dependency.
7
8 -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Tue, 03 Nov 2020 13:07:45 +0100
9
1spice (0.14.3-2) unstable; urgency=medium10spice (0.14.3-2) unstable; urgency=medium
211
3 [ Christian Ehrhardt ]12 [ Christian Ehrhardt ]
@@ -22,6 +31,40 @@ spice (0.14.3-2) unstable; urgency=medium
2231
23 -- Michael Tokarev <mjt@tls.msk.ru> Thu, 29 Oct 2020 10:57:02 +030032 -- Michael Tokarev <mjt@tls.msk.ru> Thu, 29 Oct 2020 10:57:02 +0300
2433
34spice (0.14.3-1ubuntu2) groovy; urgency=medium
35
36 * SECURITY UPDATE: multiple buffer overflows in QUIC image decoding
37 - debian/patches/CVE-2020-14355-1.patch: check we have some data to
38 start decoding quic image in subprojects/spice-common/common/quic.c.
39 - debian/patches/CVE-2020-14355-2.patch: check image size in
40 quic_decode_begin in subprojects/spice-common/common/quic.c.
41 - debian/patches/CVE-2020-14355-3.patch: check RLE lengths in
42 subprojects/spice-common/common/quic_tmpl.c.
43 - debian/patches/CVE-2020-14355-4.patch: avoid possible buffer overflow
44 in find_bucket in subprojects/spice-common/common/quic_family_tmpl.c.
45 - CVE-2020-14355
46
47 -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Thu, 01 Oct 2020 07:00:18 -0400
48
49spice (0.14.3-1ubuntu1) groovy; urgency=medium
50
51 * Merge with Debian unstable (LP: #1881093). Remaining changes:
52 - d/control: Don't recommend -libav gstreamer plugins since it is in
53 universe
54 - make autopkgtests work again
55 - d/t/automated-tests: spice-common moved into dir subprojects
56 - d/t/automated-tests: option --enable-automated-tests now is always on
57 - d/t/control: make tests more debuggable by allowing stderr
58 - d/t/control: install new test dependency python-pil
59 - d/t/regression-test.py, d/t/base_test.ppm: add file dropped in release
60 tarball but needed for autopkgtests
61 - d/source/include-binaries: allow binary base_test.ppm in package
62 * Dropped changes
63 - d/p/lp-1874054-*: fix rescaling and some crashes (LP: 1874054)
64 [Upstream in 0.14.3]
65
66 -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Thu, 28 May 2020 11:56:04 +0200
67
25spice (0.14.3-1) unstable; urgency=medium68spice (0.14.3-1) unstable; urgency=medium
2669
27 * new upstream version (Closes: #940057, #954629)70 * new upstream version (Closes: #940057, #954629)
@@ -33,6 +76,49 @@ spice (0.14.3-1) unstable; urgency=medium
3376
34 -- Michael Tokarev <mjt@tls.msk.ru> Tue, 14 Apr 2020 16:55:25 +030077 -- Michael Tokarev <mjt@tls.msk.ru> Tue, 14 Apr 2020 16:55:25 +0300
3578
79spice (0.14.2-4ubuntu3) focal; urgency=medium
80
81 * d/p/lp-1874054-*: fix rescaling and some crashes (LP: #1874054)
82
83 -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Tue, 21 Apr 2020 14:05:18 +0200
84
85spice (0.14.2-4ubuntu2) focal; urgency=medium
86
87 * No-change rebuild for libgcc-s1 package name change.
88
89 -- Matthias Klose <doko@ubuntu.com> Mon, 23 Mar 2020 07:26:08 +0100
90
91spice (0.14.2-4ubuntu1) focal; urgency=medium
92
93 * Merge with Debian unstable (LP: #1852439). Remaining changes:
94 - d/control: Don't recommend -libav gstreamer plugins since it is in
95 universe
96 - make autopkgtests work again
97 - d/t/automated-tests: spice-common moved into dir subprojects
98 - d/t/automated-tests: option --enable-automated-tests now is always on
99 - d/t/control: make tests more debuggable by allowing stderr
100 - d/t/control: install new test dependency python-pil
101 - d/t/regression-test.py, d/t/base_test.ppm: add file dropped in release
102 tarball but needed for autopkgtests
103 - d/source/include-binaries: allow binary base_test.ppm in package
104 * Added changes:
105 - d/t/automated-tests, d/t/control: make autopkgtests python3 compatible
106 * Dropped Changes (in Debian):
107 - d/control: Don't recommend -ugly gstreamer plugins since it is in universe
108 - d/patches: drop patches being upstream in 0.14.2
109 - new upstream 0.14.2
110 - disable failing test-listen
111 - d/libspice-server1.symbols: update for new symbols in 14.2
112 - d/p/fix-test-qxl-parsing-on-ppc64el-and-armhf.patch: avoid FTBFS due to
113 different handling of high words for constants
114 - d/control: bump build dependency to libspice-protocol-dev >=0.14.0
115 * Dropped Changes (Upstream)
116 - SECURITY UPDATE: Integer overflow and buffer overflow CVE-2017-12194
117 - SECURITY UPDATE: Denial of service CVE-2018-10873
118 - SECURITY UPDATE: off-by-one error in memslot_get_virt CVE-2019-3813
119
120 -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Wed, 13 Nov 2019 15:54:00 +0100
121
36spice (0.14.2-4) unstable; urgency=medium122spice (0.14.2-4) unstable; urgency=medium
37123
38 * disable failing test-listen (Closes: #941006)124 * disable failing test-listen (Closes: #941006)
@@ -80,6 +166,42 @@ spice (0.14.2-1) unstable; urgency=medium
80166
81 -- Michael Tokarev <mjt@tls.msk.ru> Fri, 30 Aug 2019 13:54:00 +0300167 -- Michael Tokarev <mjt@tls.msk.ru> Fri, 30 Aug 2019 13:54:00 +0300
82168
169spice (0.14.2-0ubuntu2) eoan; urgency=medium
170
171 * Fixup autpkgtest (LP: #1834286)
172 These changes will make the test able to run again, but not output mismatch
173 errors (this matches the behavior before 0.14.2). Upstream discussion
174 started on how to resolve that as a next step, more details at the LP bug.
175 - d/t/automated-tests: spice-common moved into dir subprojects
176 - d/t/automated-tests: option --enable-automated-tests now is always on"
177 - d/t/automated-tests, d/t/control: make tests more debuggable by allowing
178 stderr
179 - d/t/control: install new test dependency python-pil
180 - d/t/base_test.ppm, d/t/regression-test.py: provide test resources from
181 upstream git not part of the released tarball anymore
182 - d/source/include-binaries: allow binary base_test.ppm in package
183
184 -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Tue, 25 Jun 2019 12:59:01 +0200
185
186spice (0.14.2-0ubuntu1) eoan; urgency=medium
187
188 * New upstream release
189 Among many other fixes this will resolve (LP: #1814146)
190 - d/p/disable-failing-test-listen.patch: disable new test that is
191 unreliable in the build environment
192 - d/patches: drop patches being upstream in 0.14.2
193 + debian/patches/CVE-2017-12194-1.patch
194 + debian/patches/CVE-2017-12194-2.patch
195 + debian/patches/CVE-2017-12194-3.patch
196 + debian/patches/CVE-2018-10873.patch
197 + debian/patches/CVE-2019-3813.patch
198 - d/libspice-server1.symbols: update for new symbols in 14.2
199 - d/p/fix-test-qxl-parsing-on-ppc64el-and-armhf.patch: avoid FTBFS due
200 to different handling of high words for constants
201 - d/control: bump build dependency to libspice-protocol-dev >=0.14.0
202
203 -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Fri, 24 May 2019 12:27:26 +0200
204
83spice (0.14.0-1.3) unstable; urgency=medium205spice (0.14.0-1.3) unstable; urgency=medium
84206
85 * Non-maintainer upload.207 * Non-maintainer upload.
@@ -102,6 +224,52 @@ spice (0.14.0-1.1) unstable; urgency=medium
102224
103 -- Salvatore Bonaccorso <carnil@debian.org> Sat, 15 Sep 2018 09:15:28 +0200225 -- Salvatore Bonaccorso <carnil@debian.org> Sat, 15 Sep 2018 09:15:28 +0200
104226
227spice (0.14.0-1ubuntu5) disco; urgency=medium
228
229 * SECURITY UPDATE: off-by-one error in memslot_get_virt
230 - debian/patches/CVE-2019-3813.patch: fix checks in server/memslot.c,
231 add tests to server/tests/test-qxl-parsing.c.
232 - CVE-2019-3813
233 * debian/tests/automated-tests: fix incorrect test name, don't fail on
234 build writing to stderr.
235
236 -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Thu, 24 Jan 2019 08:58:10 -0500
237
238spice (0.14.0-1ubuntu4) cosmic; urgency=medium
239
240 * SECURITY UPDATE: Denial of service
241 - debian/patches/CVE-2018-10873.patch: fix in
242 spice-common/python_modules/demarshal.py,
243 - CVE-2018-10873
244
245 -- Leonidas S. Barbosa <leo.barbosa@canonical.com> Mon, 20 Aug 2018 13:26:02 -0300
246
247spice (0.14.0-1ubuntu3) cosmic; urgency=medium
248
249 * SECURITY UPDATE: Integer overflow and buffer overflow
250 - debian/patches/CVE-2017-12194-1.patch: fix a integer overflow
251 computing sizes in spice-common/python_modules/demarshal.py.
252 - debian/patches/CVE-2017-12194-2.patch: avoid integer overflow
253 in spice-common/python_modules/demarshal.py,
254 spice-common/python_modules/marshal.py.
255 - debian/patches/CVE-2017-12194-3.patch: add tests to verify fix.
256 - CVE-2017-12194
257
258 -- Leonidas S. Barbosa <leo.barbosa@canonical.com> Tue, 22 May 2018 14:53:01 -0300
259
260spice (0.14.0-1ubuntu2) bionic; urgency=high
261
262 * No change rebuild against openssl1.1.
263
264 -- Dimitri John Ledkov <xnox@ubuntu.com> Tue, 06 Feb 2018 17:55:31 +0000
265
266spice (0.14.0-1ubuntu1) bionic; urgency=medium
267
268 * Don't recommend -ugly or -libav gstreamer plugins since they
269 are in universe
270
271 -- Jeremy Bicha <jbicha@ubuntu.com> Wed, 01 Nov 2017 21:55:03 -0400
272
105spice (0.14.0-1) unstable; urgency=medium273spice (0.14.0-1) unstable; urgency=medium
106274
107 * New upstream release275 * New upstream release
diff --git a/debian/control b/debian/control
index d31bb2c..9813c7d 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
1Source: spice1Source: spice
2Section: misc2Section: misc
3Priority: optional3Priority: optional
4Maintainer: Debian QEMU Team <pkg-qemu-devel@lists.alioth.debian.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Debian QEMU Team <pkg-qemu-devel@lists.alioth.debian.org>
5Uploaders: Michael Tokarev <mjt@tls.msk.ru>6Uploaders: Michael Tokarev <mjt@tls.msk.ru>
6Build-Depends:7Build-Depends:
7 debhelper-compat (= 12),8 debhelper-compat (= 12),
@@ -39,10 +40,10 @@ Multi-Arch: same
39Pre-Depends: ${misc:Pre-Depends}40Pre-Depends: ${misc:Pre-Depends}
40Depends: ${misc:Depends}, ${shlibs:Depends}41Depends: ${misc:Depends}, ${shlibs:Depends}
41Recommends:42Recommends:
42 gstreamer1.0-libav,
43 gstreamer1.0-plugins-base,43 gstreamer1.0-plugins-base,
44 gstreamer1.0-plugins-good,44 gstreamer1.0-plugins-good,
45Suggests:45Suggests:
46 gstreamer1.0-libav,
46 gstreamer1.0-plugins-ugly,47 gstreamer1.0-plugins-ugly,
47Description: Implements the server side of the SPICE protocol48Description: Implements the server side of the SPICE protocol
48 The Simple Protocol for Independent Computing Environments (SPICE) is49 The Simple Protocol for Independent Computing Environments (SPICE) is

Subscribers

People subscribed via source and target branches