Ubuntu
rabbitmq-server package

Code review comment for ~paelzer/ubuntu/+source/rabbitmq-server:lp-1988283-fix-mnesia-error-KINETIC

  1. Git
  2. lp:~paelzer/ubuntu/+source/rabbitmq-server
  3. lp-1988283-fix-mnesia-error-KINETIC
  4. Merge into ubuntu/kinetic-devel
Revision history for this message
Paride Legovini (paride) wrote :

Patch itself, headers and other packaging changes all LGTM. The package built fine in the PPA.

One nit on the patch file: the

  From: =?UTF-8?...

thing is a bit ugly and I think nothing is going to parse it. I see that's how GitHub outputs patch files. Not really worth fixing unless the branch has to be updated for other reasons.

Approving but I agree with [1] in that we need user's feedback on the PPA packages before uploading to Kinetic.

[1] https://bugs.launchpad.net/ubuntu/+source/rabbitmq-server/+bug/1988283/comments/3

review: Approve
Reply

« Back to merge proposal