Code review comment for ~paelzer/ubuntu/+source/qemu:lp-2051153-fix-run-qemu-mount-restart-JAMMY
Revision history for this message
| Christian Ehrhardt (paelzer) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Thank you
On "sed here vs. just dumping the contents of the #DEBHELPER#" I hav egon through the same thinking.
But debhelper does so much, and if we change qemu-guest agent or any other I'd want to at least be able to use normal changes (unless they are in vain like in this case). Therefore I didn't want to remove #DEBHELPER# from the maintscript and instead chose the most surgical approach (there is much more it does for that mount unit that mostly has no effect, but I decided to keep it as is as it also has no negative effect as far as we know).
I'm ok having the original call commented out and followed your suggestion.
Let me test rebuild that to be sure we miss no special char escaping or any such ...
Once that looks good I'll upload for SRU review ...