Code review comment for ~paelzer/ubuntu/+source/qemu:merge-5.2-3

Paride Legovini (paride) wrote :

* Changelog:
  - [✓] old content and logical tag match as expected
  - [✓] changelog entry correct version and targeted codename
  - [✓] changelog entries correct
  - [✓] update-maintainer has been run

* Actual changes:
  - [✓] no upstream changes to consider
  - [✓] no further upstream version to consider
  - [✓] debian changes look safe

* Old Delta:
  - [ ] dropped changes are ok to be dropped
  - [✓] nothing else to drop
  - [ ] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [✓] no new patches added
  - [ ] patches match what was proposed upstream
  - [ ] patches correctly included in debian/patches/series
  - [ ] patches have correct DEP3 metadata

* Build/Test:
  - [✓] build is ok
  - [✓] verified PPA package installs/uninstalls
  - [ ] autopkgtest against the PPA package passes
  - [✓] sanity checks test fine

review: Approve

« Back to merge proposal