Code review comment for ~paelzer/ubuntu/+source/qemu:lp1776189-hpb-cosmic

Revision history for this message
Robie Basak (racb) wrote :

Looks good, thanks. I appreciate the detailed description and rationale included. A few minor inline comments.

The patch itself I'm not confident in reviewing myself in detail as I'm not familiar with qemu internals. It looks reasonable to me though, and doesn't look like it'll impact anything else as it's adding a new type rather than making changes to anything existing. I did try to compare to RH's patch but as that one changes an existing machine type it is rather different.

Maybe get Ryan to review the qemu patch, if time permits?

« Back to merge proposal