Code review comment for ~paelzer/ubuntu/+source/postgresql-9.5:MRE-xenial-9.5.17

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

It is in the branch for me ?!:

$ git status doc/src/sgml/html/release-9-5-17.html
On branch MRE-xenial-9.5.17
nothing to commit, working tree clean
$ ll doc/src/sgml/html/release-9-5-17.html
-rw-r--r-- 1 paelzer paelzer 14787 Mai 6 23:04 doc/src/sgml/html/release-9-5-17.html

I really wonder what is going on with these release html files for you.
They are there for me.

Cloning a new branch in an empty dir ...
This shows what you are seeing - odd.

$ git ubuntu clone postgresql-9.5
# adds my remote automatically
$ cd postgresql-9.5
$ git checkout MRE-xenial-9.5.17
$ ll doc/src/sgml/html/release-9-5-17.html
ls: cannot access 'doc/src/sgml/html/release-9-5-17.html': No such file or directory

Maybe a git ignore or something that prevents htmls being added?

$ git status --ignored
On branch MRE-xenial-9.5.17
Ignored files:
        doc/src/sgml/html/release-9-5-17.html

That is not very helpful postgresql :-)
Even if I clean .gitignore completely it still is ignored.
There is a lower .gitignore doc/src/sgml/.gitignore which is part of the tarball.

I replaced in my script
$ git add *
with
$ git add -f .

That will avoid this in the future.
For now I'll add this to all branches which then should be good to ack given that nothing else was missing.

« Back to merge proposal