Code review comment for ~paelzer/ubuntu/+source/pollinate:lp-1848923-cache-directory-HIRSUTE

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

On upgrade (as before) it does not restart as the path exists already:

  Condition: start condition failed at Tue 2021-02-09 10:49:28 UTC; 3s ago
             └─ ConditionPathExists=!/var/cache/pollinate/seeded was not met

The old pre-existing path is NOT killed/removed which is good.

If someone clears /var/cache on next service start (e.g. reboot) the path it
a) recreated as before (same owner)
b) the service runs again as expected

sudo ls -laF /var/cache/pollinate/; systemctl status pollinate
total 8
drwxr-xr-x 2 pollinate daemon 4096 Feb 9 10:51 ./
drwxr-xr-x 13 root root 4096 Feb 9 10:51 ../
-rw-r--r-- 1 pollinate daemon 0 Feb 9 10:51 seeded
● pollinate.service - Pollinate to seed the pseudo random number generator
     Loaded: loaded (/lib/systemd/system/pollinate.service; enabled; vendor preset: enabled)
     Active: inactive (dead) since Tue 2021-02-09 10:51:28 UTC; 14s ago
       Docs: https://launchpad.net/pollinate
    Process: 595 ExecStart=/usr/bin/pollinate (code=exited, status=0/SUCCESS)
   Main PID: 595 (code=exited, status=0/SUCCESS)

Feb 09 10:51:27 h-pol systemd[1]: Starting Pollinate to seed the pseudo random number generator...
Feb 09 10:51:27 h-pol pollinate[661]: client sent challenge to [https://entropy.ubuntu.com/]
Feb 09 10:51:28 h-pol pollinate[708]: client verified challenge/response with [https://entropy.ubuntu.com/]
Feb 09 10:51:28 h-pol pollinate[717]: client hashed response from [https://entropy.ubuntu.com/]
Feb 09 10:51:28 h-pol pollinate[718]: client successfully seeded [/dev/urandom]
Feb 09 10:51:28 h-pol systemd[1]: pollinate.service: Succeeded.
Feb 09 10:51:28 h-pol systemd[1]: Finished Pollinate to seed the pseudo random number generator.

Yet there is a difference in the permissions
old:
drwxr-x--- 2 pollinate daemon 4096 Feb 5 07:57 ./
new:
drwxr-xr-x 2 pollinate daemon 4096 Feb 9 10:51 ./

This should do the trick:
CacheDirectoryMode=0750

« Back to merge proposal