Code review comment for ~paelzer/ubuntu/+source/pgpool2:lp1777418-fix-arm-crash

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Looks good, +1. Great work on the analysis, specially on a non-traditional arch. I started this review by preparing my raspberrypi3 but will just give up, so slow it is :)

One comment only, entirely optional. It's just that I have been given this kind of review feedback in the past about patches. It was suggested that they be "clean" without the equivalent of --show-c-functions bits, i.e.:

+@@ -3139,7 +3139,7 @@

instead of

+@@ -3139,7 +3139,7 @@ void per_node_error_log(POOL_CONNECTION_POOL *backend, int node_id, char *query,

One way to do it, assuming you have ~/.quiltrc & friends setup up like that, is to just refresh it:
dquilt push lp1777418-fix-arm-crash.patch
dquilt refresh lp1777418-fix-arm-crash.patch
dquilt pop -a

Just a comment, +1 without that.

review: Approve

« Back to merge proposal